fix(view): treemap with its layered fills again, the BI order below the aggregations #8

Merged
dawid merged 1 commit from treemap-layers into main 2026-11-19 21:35:09 +00:00
Owner

The treemap of #7 looked odd: its opaque fills drew an OK rule in the same color as its parent, so the rectangles of a level ran into one another, and sorting the rules worst first turned a tiny problem rule into a thin strip along the top.

Back:

  • the pale fills, which add up to a brighter one each level down and so set the levels apart;
  • black names;
  • the BI order below the aggregations, which leaves a small problem rule in a corner.

Kept from #7:

  • the worst aggregations first (top left);
  • the chart within its box (it was cut off on the right);
  • no drill-down icon;
  • the names without their parent's in front ("Frontend" below "Web Shop").

The helper for opaque fills goes, and its test checks only the order now. The README's treemap screenshot is regenerated; the 86 unit tests pass.

The treemap of #7 looked odd: its opaque fills drew an OK rule in the same color as its parent, so the rectangles of a level ran into one another, and sorting the rules worst first turned a tiny problem rule into a thin strip along the top. Back: - the pale fills, which add up to a brighter one each level down and so set the levels apart; - black names; - the BI order below the aggregations, which leaves a small problem rule in a corner. Kept from #7: - the worst aggregations first (top left); - the chart within its box (it was cut off on the right); - no drill-down icon; - the names without their parent's in front ("Frontend" below "Web Shop"). The helper for opaque fills goes, and its test checks only the order now. The README's treemap screenshot is regenerated; the 86 unit tests pass.
fix(view): treemap with its layered fills again, the BI order below the aggregations
Some checks failed
CI / unit (pull_request) Successful in 1m47s
CI / integration (Checkmk 2.4) (pull_request) Failing after 5m52s
CI / integration (Checkmk 2.5) (pull_request) Failing after 6m3s
CI / integration (update 2.4 to 2.5) (pull_request) Successful in 7m31s
CI / release (pull_request) Has been skipped
c49d993bd7
The opaque fills of the last change drew an OK rule in its parent's color, so the
rectangles of a level ran into one another, and sorting the rules worst first made
a tiny problem rule a thin strip along the top. Back: the pale fills, which add up
to a brighter one each level down, black names and the BI order below the
aggregations. Kept: the worst aggregations first, the chart within its box, no
drill-down icon and the names without their parent's in front.
dawid merged commit bbc175ce1b into main 2026-11-19 21:35:09 +00:00
dawid deleted branch treemap-layers 2026-11-19 21:35:09 +00:00

Tests of CI / unit: passed

86 passed, 0 failed, 0 skipped (86 tests, 55.5 s)

Of c49d993bd7, the run, updated by every run.

<!-- ci-report tests: CI-unit --> ### Tests of CI / unit: passed **86 passed, 0 failed, 0 skipped** (86 tests, 55.5 s) <sub>Of c49d993bd7, [the run](https://git.ciepiela.org/dawid/checkmk-bi-charts/actions/runs/21), updated by every run.</sub>

Tests of CI / integration (Checkmk 2.4): failed

17 passed, 1 failed, 0 skipped (18 tests, 298.9 s)

Failed tests

tests.integration.test_checkmk.test_page_draws_the_trees_in_a_browser[2.4-chromium-sankey]
…
.venv/lib/python3.12/site-packages/playwright/_impl/frame.py:1209: in wait_for_function
    result = await self._channel.waitForFunction(
.venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:398: in _mapped
    return mapper(await awaitable)
                  ^^^^^^^^^^^^^^^
.venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:387: in finish
    raise e from None
.venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:352: in finish
    result = await zone.run_async(lambda: awaitable)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <playwright._impl.utils.zones.Zone object at 0x768593d44d10>
func = <function ChannelOwner._wrap_api_call.<locals>.finish.<locals>.<lambda> at 0x768593d5ae80>

    async def run_async(self, func: Callable[[], Awaitable[R]]) -> R:
        # Python: run() of an async function. The coroutine runs when it is awaited,
        # so the zone must be current while it is awaited, not while it is created.
        token = _async_local_storage.set(self)
        try:
>           return await func()
                   ^^^^^^^^^^^^
E           playwright._impl._errors.TimeoutError: Page.wait_for_function: Timeout 60000ms exceeded.

.venv/lib/python3.12/site-packages/playwright/_impl/utils/zones.py:58: TimeoutError

Of c49d993bd7, the run, updated by every run.

<!-- ci-report tests: CI-integration-Checkmk-2.4- --> ### Tests of CI / integration (Checkmk 2.4): failed **17 passed, 1 failed, 0 skipped** (18 tests, 298.9 s) #### Failed tests <details><summary><code>tests.integration.test_checkmk.test_page_draws_the_trees_in_a_browser[2.4-chromium-sankey]</code></summary> ```text … .venv/lib/python3.12/site-packages/playwright/_impl/frame.py:1209: in wait_for_function result = await self._channel.waitForFunction( .venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:398: in _mapped return mapper(await awaitable) ^^^^^^^^^^^^^^^ .venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:387: in finish raise e from None .venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:352: in finish result = await zone.run_async(lambda: awaitable) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <playwright._impl.utils.zones.Zone object at 0x768593d44d10> func = <function ChannelOwner._wrap_api_call.<locals>.finish.<locals>.<lambda> at 0x768593d5ae80> async def run_async(self, func: Callable[[], Awaitable[R]]) -> R: # Python: run() of an async function. The coroutine runs when it is awaited, # so the zone must be current while it is awaited, not while it is created. token = _async_local_storage.set(self) try: > return await func() ^^^^^^^^^^^^ E playwright._impl._errors.TimeoutError: Page.wait_for_function: Timeout 60000ms exceeded. .venv/lib/python3.12/site-packages/playwright/_impl/utils/zones.py:58: TimeoutError ``` </details> <sub>Of c49d993bd7, [the run](https://git.ciepiela.org/dawid/checkmk-bi-charts/actions/runs/21), updated by every run.</sub>

Tests of CI / integration (Checkmk 2.5): failed

17 passed, 1 failed, 0 skipped (18 tests, 310.5 s)

Failed tests

tests.integration.test_checkmk.test_page_draws_the_trees_in_a_browser[2.5-chromium-sankey]
…
.venv/lib/python3.12/site-packages/playwright/_impl/frame.py:1209: in wait_for_function
    result = await self._channel.waitForFunction(
.venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:398: in _mapped
    return mapper(await awaitable)
                  ^^^^^^^^^^^^^^^
.venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:387: in finish
    raise e from None
.venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:352: in finish
    result = await zone.run_async(lambda: awaitable)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <playwright._impl.utils.zones.Zone object at 0x76eaa5ec1310>
func = <function ChannelOwner._wrap_api_call.<locals>.finish.<locals>.<lambda> at 0x76eaa5ed6e80>

    async def run_async(self, func: Callable[[], Awaitable[R]]) -> R:
        # Python: run() of an async function. The coroutine runs when it is awaited,
        # so the zone must be current while it is awaited, not while it is created.
        token = _async_local_storage.set(self)
        try:
>           return await func()
                   ^^^^^^^^^^^^
E           playwright._impl._errors.TimeoutError: Page.wait_for_function: Timeout 60000ms exceeded.

.venv/lib/python3.12/site-packages/playwright/_impl/utils/zones.py:58: TimeoutError

Of c49d993bd7, the run, updated by every run.

<!-- ci-report tests: CI-integration-Checkmk-2.5- --> ### Tests of CI / integration (Checkmk 2.5): failed **17 passed, 1 failed, 0 skipped** (18 tests, 310.5 s) #### Failed tests <details><summary><code>tests.integration.test_checkmk.test_page_draws_the_trees_in_a_browser[2.5-chromium-sankey]</code></summary> ```text … .venv/lib/python3.12/site-packages/playwright/_impl/frame.py:1209: in wait_for_function result = await self._channel.waitForFunction( .venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:398: in _mapped return mapper(await awaitable) ^^^^^^^^^^^^^^^ .venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:387: in finish raise e from None .venv/lib/python3.12/site-packages/playwright/_impl/channel_owner.py:352: in finish result = await zone.run_async(lambda: awaitable) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <playwright._impl.utils.zones.Zone object at 0x76eaa5ec1310> func = <function ChannelOwner._wrap_api_call.<locals>.finish.<locals>.<lambda> at 0x76eaa5ed6e80> async def run_async(self, func: Callable[[], Awaitable[R]]) -> R: # Python: run() of an async function. The coroutine runs when it is awaited, # so the zone must be current while it is awaited, not while it is created. token = _async_local_storage.set(self) try: > return await func() ^^^^^^^^^^^^ E playwright._impl._errors.TimeoutError: Page.wait_for_function: Timeout 60000ms exceeded. .venv/lib/python3.12/site-packages/playwright/_impl/utils/zones.py:58: TimeoutError ``` </details> <sub>Of c49d993bd7, [the run](https://git.ciepiela.org/dawid/checkmk-bi-charts/actions/runs/21), updated by every run.</sub>

Tests of CI / integration (update 2.4 to 2.5): passed

6 passed, 0 failed, 0 skipped (6 tests, 395.7 s)

Of c49d993bd7, the run, updated by every run.

<!-- ci-report tests: CI-integration-update-2.4-to-2.5- --> ### Tests of CI / integration (update 2.4 to 2.5): passed **6 passed, 0 failed, 0 skipped** (6 tests, 395.7 s) <sub>Of c49d993bd7, [the run](https://git.ciepiela.org/dawid/checkmk-bi-charts/actions/runs/21), updated by every run.</sub>
Sign in to join this conversation.
No description provided.